Skip to content

Rollup of 7 pull requests #102526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Oct 1, 2022
Merged

Rollup of 7 pull requests #102526

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
27b280e
Fix ICE in const_trait check code
fee1-dead Sep 27, 2022
8a96884
Flush delayed bugs before codegen
Noratrieb Sep 27, 2022
c1c3dac
Generate synthetic impl region even in closure body in associated fn
compiler-errors Sep 29, 2022
3722ad4
Don't lower assoc bindings just to deny them
compiler-errors Sep 29, 2022
d7fe44d
Use let chains instead of let else
fee1-dead Sep 30, 2022
477846f
Add comment explaining why we flush delayed bugs before codegen
Noratrieb Sep 30, 2022
8728e17
rustdoc: add missing margin to no-docblock methods
notriddle Sep 30, 2022
f145f28
rustdoc: add missing margin to no-docblock trait items
notriddle Sep 30, 2022
1dcbe72
rustdoc: add gui test for no-docblock margins
notriddle Sep 30, 2022
4b1cf84
Update compiler/rustc_interface/src/queries.rs
cjgillot Sep 30, 2022
b2bef02
create def ids for impl traits during ast lowering
spastorino Sep 30, 2022
8308c4b
rustdoc: update test cases for `<section>` tags in traits
notriddle Sep 30, 2022
e8f1bfe
Fix typo
Noratrieb Sep 30, 2022
5ab68a8
Group together more size assertions.
nnethercote Sep 29, 2022
c07ebeb
Rollup merge of #102361 - fee1-dead-contrib:fix-102156, r=eholk
matthiaskrgr Sep 30, 2022
9ec772e
Rollup merge of #102373 - Nilstrieb:cannot-get-layout-of-branch-error…
matthiaskrgr Sep 30, 2022
05b9f0e
Rollup merge of #102483 - spastorino:create-defs-on-lowering, r=cjgillot
matthiaskrgr Sep 30, 2022
808f197
Rollup merge of #102490 - compiler-errors:closure-body-impl-lifetime,…
matthiaskrgr Sep 30, 2022
842a7d3
Rollup merge of #102492 - compiler-errors:simplify-deny-assoc-binding…
matthiaskrgr Sep 30, 2022
eaf1c7a
Rollup merge of #102493 - nnethercote:improve-size-assertions-some-mo…
matthiaskrgr Sep 30, 2022
2fadfe0
Rollup merge of #102521 - notriddle:notriddle/impl-items-section, r=G…
matthiaskrgr Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rustdoc: add missing margin to no-docblock methods 
Fixes another regression caused by 8846c08,
this time fixing the appearance of methods that have no docblock (we didn't
notice this one because libstd docs *always* have docblocks).

See how it looks without the fix at https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc/clean/types/enum.Type.html#implementations
  • Loading branch information
@notriddle
notriddle committed Sep 30, 2022
commit 8728e178554eb7b0eeb4d8c2e254b07a3bccd4cb
4 changes: 3 additions & 1 deletion src/librustdoc/html/static/css/rustdoc.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2008,7 +2008,9 @@ in storage.js plus the media query with (min-width: 701px)
.method-toggle summary,
.implementors-toggle summary,
.impl,
#implementors-list > .docblock {
#implementors-list > .docblock,
.impl-items > section,
{
margin-bottom: 0.75em;
}

Expand Down