Skip to content

Rollup of 7 pull requests #102471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 29, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
259bbfb
Add negation methods for signed non-zero integers.
jmillikin Sep 18, 2022
cca4828
Format type_of
compiler-errors Sep 26, 2022
05267b5
Make type_of work correctly for const arg bindings
compiler-errors Sep 26, 2022
92561f4
Support bindings with anon consts in generics
compiler-errors Sep 26, 2022
7f06d51
Don't export `__heap_base` and `__data_end` on wasm32-wasi.
sunfishcode Sep 28, 2022
cdae82c
nonzero_negation_ops: Set `issue = "102443"`.
jmillikin Sep 28, 2022
ceb53a3
nonzero_negation_ops: `inline(always)` -> `inline`.
jmillikin Sep 28, 2022
f55ea41
rustdoc: clean up "normalize.css 8" input override CSS
notriddle Sep 28, 2022
49b25d3
Improve example of Iterator::reduce
GuillaumeGomez Sep 28, 2022
269ff92
Use let-chaining in `WhileTrue::check_expr`.
nnethercote Sep 28, 2022
06624e8
fix minor ungrammatical sentence
granolocks Sep 29, 2022
1be9ec5
Rollup merge of #102336 - compiler-errors:issue-102333, r=jackh726
Dylan-DPC Sep 29, 2022
609152a
Rollup merge of #102342 - jmillikin:nonzero-negation, r=scottmcm
Dylan-DPC Sep 29, 2022
33553e1
Rollup merge of #102385 - sunfishcode:sunfishcode/wasm-no-export-heap…
Dylan-DPC Sep 29, 2022
b6d1c15
Rollup merge of #102435 - GuillaumeGomez:improve-iterator-reduce-exam…
Dylan-DPC Sep 29, 2022
5f18c2b
Rollup merge of #102436 - notriddle:notriddle/normalize-form, r=Guill…
Dylan-DPC Sep 29, 2022
34f02c3
Rollup merge of #102452 - granolocks:grammar-tweak, r=thomcc
Dylan-DPC Sep 29, 2022
f4e7094
Rollup merge of #102455 - nnethercote:WhileTrue-check_expr, r=lqd
Dylan-DPC Sep 29, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rustdoc: clean up "normalize.css 8" input override CSS
These rules were copied from normalize.css 3, and are mostly redundant.

* `optgroup` isn't used in rustdoc at all
* `textarea` is only used for the "copy" button, so it's not visible
* The remaining buttons and inputs mostly have styles set anyway.
* We should never be setting `color` without also setting the
  background to something. Otherwise, you get white-on-gray
  text. That seems to be [the reason] why `normalize.css` changed this.

[the reason]: necolas/normalize.css#502
  • Loading branch information
notriddle committed Sep 28, 2022
commit f55ea418c3a85061ae681f7b8a589f41b582be7f
21 changes: 9 additions & 12 deletions src/librustdoc/html/static/css/rustdoc.css
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ h4.code-header {
position: relative;
}

#crate-search,
h1, h2, h3, h4, h5, h6,
.sidebar,
.mobile-topbar,
Expand Down Expand Up @@ -304,16 +305,6 @@ summary {

/* Fix some style changes due to normalize.css 8 */

button,
input,
optgroup,
select,
textarea {
color: inherit;
font: inherit;
margin: 0;
}

button {
/* Buttons on Safari have different default padding than other platforms. Make them the same. */
padding: 1px 6px;
Expand Down Expand Up @@ -887,6 +878,9 @@ table,
/* Removes default arrow from firefox */
text-indent: 0.01px;
background-color: var(--main-background-color);
color: inherit;
line-height: 1.5;
font-weight: 500;
}
/* cancel stylistic differences in padding in firefox
for "appearance: none"-style (or equivalent) <select>s */
Expand Down Expand Up @@ -1363,6 +1357,8 @@ pre.rust {
border: 0;
border-top: 2px solid;
flex: 1;
line-height: 1.5;
color: inherit;
}

#titles > button > div.count {
Expand All @@ -1380,7 +1376,6 @@ pre.rust {
position: sticky;
top: 0;
left: 0;
font-weight: bold;
font-size: 1.25rem;
border-bottom: 1px solid;
display: flex;
Expand All @@ -1400,6 +1395,8 @@ pre.rust {
margin-bottom: 6px;
}
#sidebar-toggle > button {
font-size: inherit;
font-weight: bold;
background: none;
color: inherit;
cursor: pointer;
Expand Down Expand Up @@ -1428,6 +1425,7 @@ pre.rust {
border: 1px solid var(--border-color);
border-radius: 2px;
cursor: pointer;
line-height: 1.5;
}

#settings-menu > a, #help-button > button {
Expand Down Expand Up @@ -1887,7 +1885,6 @@ in storage.js plus the media query with (min-width: 701px)
border-top-right-radius: 3px;
border-bottom-right-radius: 3px;
cursor: pointer;
font-weight: bold;
border: 1px solid;
border-left: 0;
}
Expand Down
3 changes: 2 additions & 1 deletion src/librustdoc/html/static/css/settings.css
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
margin-right: 0.3em;
height: 1.2rem;
width: 1.2rem;
border: 1px solid;
color: inherit;
border: 1px solid currentColor;
outline: none;
-webkit-appearance: none;
cursor: pointer;
Expand Down