Skip to content

Rollup of 7 pull requests #101910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e2866c0
Add simd_cast_ptr, simd_expose_addr, and simd_from_exposed_addr intri…
calebzulawski Jul 22, 2022
d00928a
Require pointers to be sized
calebzulawski Aug 4, 2022
3f2ce06
Check pointer metadata rather than pointee size
calebzulawski Aug 27, 2022
d7b9221
change AccessLevels representation
Bryanskiy Sep 12, 2022
d657d1f
Disallow defaults on type GATs
jackh726 Sep 14, 2022
bca3cf7
Stabilize the let_else feature
est31 Aug 30, 2022
5633e86
Remove feature gate from let else suggestion
est31 May 16, 2022
173eb6f
Only enable the let_else feature on bootstrap
est31 Feb 27, 2022
9c7ae38
Remove the let_else feature gate from the testsuite
est31 Feb 27, 2022
37dde3f
Fix clippy
est31 Feb 4, 2022
ccd4383
Add a new component, `rust-json-docs`, to distribute the JSON-formatt…
Sep 14, 2022
d433efa
more simple formatting
Rageking8 Sep 16, 2022
99c0071
Remove some unused CSS rules
GuillaumeGomez Sep 16, 2022
7cf67bf
Remove unused `.block a.current*` rules
GuillaumeGomez Sep 16, 2022
28956d1
Remove unneeded empty ayu CSS rules
GuillaumeGomez Sep 16, 2022
d5fadc4
Rollup merge of #93628 - est31:stabilize_let_else, r=joshtriplett
GuillaumeGomez Sep 16, 2022
87ecd2d
Rollup merge of #98441 - calebzulawski:simd_as, r=oli-obk
GuillaumeGomez Sep 16, 2022
334b2d4
Rollup merge of #101713 - Bryanskiy:AccessLevels, r=petrochenkov
GuillaumeGomez Sep 16, 2022
a00a2d3
Rollup merge of #101799 - LukeMathWalker:distribute-json-doc, r=jyn514
GuillaumeGomez Sep 16, 2022
a75fdd9
Rollup merge of #101807 - jackh726:no-gat-defaults, r=lcnr
GuillaumeGomez Sep 16, 2022
4ffc06a
Rollup merge of #101878 - Rageking8:More-simple-formatting, r=lcnr
GuillaumeGomez Sep 16, 2022
69ea4ff
Rollup merge of #101898 - GuillaumeGomez:rm-unused-css, r=notriddle
GuillaumeGomez Sep 16, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove feature gate from let else suggestion
The let else suggestion added by 0d92752
does not need a feature gate any more.
  • Loading branch information
est31 committed Sep 15, 2022
commit 5633e863bd9b6130be0bef3ffceb6e1bca0ebb56
4 changes: 2 additions & 2 deletions compiler/rustc_mir_build/src/thir/pattern/check_match.rs
Original file line number Diff line number Diff line change
Expand Up @@ -491,8 +491,8 @@ impl<'p, 'tcx> MatchVisitor<'_, 'p, 'tcx> {
err.span_suggestion_verbose(
semi_span.shrink_to_lo(),
&format!(
"alternatively, on nightly, you might want to use \
`#![feature(let_else)]` to handle the variant{} that {} matched",
"alternatively, you might want to use \
let else to handle the variant{} that {} matched",
pluralize!(witnesses.len()),
match witnesses.len() {
1 => "isn't",
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/empty/empty-never-array.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ help: you might want to use `if let` to ignore the variant that isn't matched
|
LL | let u = if let Helper::U(u) = Helper::T(t, []) { u } else { todo!() };
| ++++++++++ ++++++++++++++++++++++
help: alternatively, on nightly, you might want to use `#![feature(let_else)]` to handle the variant that isn't matched
help: alternatively, you might want to use let else to handle the variant that isn't matched
|
LL | let Helper::U(u) = Helper::T(t, []) else { todo!() };
| ++++++++++++++++
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/error-codes/E0005.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ help: you might want to use `if let` to ignore the variant that isn't matched
|
LL | let y = if let Some(y) = x { y } else { todo!() };
| ++++++++++ ++++++++++++++++++++++
help: alternatively, on nightly, you might want to use `#![feature(let_else)]` to handle the variant that isn't matched
help: alternatively, you might want to use let else to handle the variant that isn't matched
|
LL | let Some(y) = x else { todo!() };
| ++++++++++++++++
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ help: you might want to use `if let` to ignore the variant that isn't matched
|
LL | let _x = if let Ok(_x) = foo() { _x } else { todo!() };
| +++++++++++ +++++++++++++++++++++++
help: alternatively, on nightly, you might want to use `#![feature(let_else)]` to handle the variant that isn't matched
help: alternatively, you might want to use let else to handle the variant that isn't matched
|
LL | let Ok(_x) = foo() else { todo!() };
| ++++++++++++++++
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/pattern/usefulness/issue-31561.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ help: you might want to use `if let` to ignore the variants that aren't matched
|
LL | let y = if let Thing::Foo(y) = Thing::Foo(1) { y } else { todo!() };
| ++++++++++ ++++++++++++++++++++++
help: alternatively, on nightly, you might want to use `#![feature(let_else)]` to handle the variants that aren't matched
help: alternatively, you might want to use let else to handle the variants that aren't matched
|
LL | let Thing::Foo(y) = Thing::Foo(1) else { todo!() };
| ++++++++++++++++
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ help: you might want to use `if let` to ignore the variant that isn't matched
|
LL | let _x = if let Opt::Some(ref _x) = e { _x } else { todo!() };
| +++++++++++ +++++++++++++++++++++++
help: alternatively, on nightly, you might want to use `#![feature(let_else)]` to handle the variant that isn't matched
help: alternatively, you might want to use let else to handle the variant that isn't matched
|
LL | let Opt::Some(ref _x) = e else { todo!() };
| ++++++++++++++++
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ help: you might want to use `if let` to ignore the variant that isn't matched
|
LL | let x = if let Ok(x) = res { x } else { todo!() };
| ++++++++++ ++++++++++++++++++++++
help: alternatively, on nightly, you might want to use `#![feature(let_else)]` to handle the variant that isn't matched
help: alternatively, you might want to use let else to handle the variant that isn't matched
|
LL | let Ok(x) = res else { todo!() };
| ++++++++++++++++
Expand Down
2 changes: 1 addition & 1 deletion src/test/ui/uninhabited/uninhabited-irrefutable.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ help: you might want to use `if let` to ignore the variant that isn't matched
|
LL | let (_y, _z) = if let Foo::D(_y, _z) = x { (_y, _z) } else { todo!() };
| +++++++++++++++++ +++++++++++++++++++++++++++++
help: alternatively, on nightly, you might want to use `#![feature(let_else)]` to handle the variant that isn't matched
help: alternatively, you might want to use let else to handle the variant that isn't matched
|
LL | let Foo::D(_y, _z) = x else { todo!() };
| ++++++++++++++++
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ help: you might want to use `if let` to ignore the variant that isn't matched
|
LL | let x = if let Ok(x) = x { x } else { todo!() };
| ++++++++++ ++++++++++++++++++++++
help: alternatively, on nightly, you might want to use `#![feature(let_else)]` to handle the variant that isn't matched
help: alternatively, you might want to use let else to handle the variant that isn't matched
|
LL | let Ok(x) = x else { todo!() };
| ++++++++++++++++
Expand Down