Skip to content

Drop support for DebuggerTools being invoked from the top-level bootstrap CLI #95992

Closed
@jyn514

Description

@jyn514

@Mark-Simulacrum mentioned we'd also need some work to ensure they're in dist tarballs, but it looks like they're already present:

rust/src/bootstrap/dist.rs

Lines 433 to 435 in 52ca603

// Debugger scripts
builder
.ensure(DebuggerScripts { sysroot: INTERNER.intern_path(image.to_owned()), host });

So I think this is as simple as changing

rust/src/bootstrap/dist.rs

Lines 455 to 459 in 52ca603

impl Step for DebuggerScripts {
type Output = ();
fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
run.path("src/lldb_batchmode.py")
to run.never() and deleting
dist::DebuggerScripts,

Originally posted by @Mark-Simulacrum in #95906 (comment)

Metadata

Metadata

Assignees

Labels

E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions