Skip to content

The two unsafe functions in std::ascii might be unnecessary. #9058

Closed
@Kimundi

Description

@Kimundi

PLACEHOLDER: FUNCTIONS ARE PART OF A UNLANDED PULL REQUEST


std::ascii contains the two unsafe functions str_map_bytes and str_copy_map_bytes. Both implement mapping a look up table over an byte vector using unsafe code and pointer arithmetic. It is unclear if that's intentionally done for speed, or whether an more idiomatic implementation using iterators would be just as fast. In case of the latter, the functions should probably be rewritten/removed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions