Skip to content

npm list checks added in #84586 regress wall time of running tidy #86147

Closed

Description

#84586 introduced some checks which execute npm list 4 times. They run unconditionally when executing ./x.py test ..., even if it is just to run tidy. On my system the added wall time exceeds that of running tidy itself.

I'll look into whether the checks themselves can be made be less wasteful. But if there are suggestions how to completely eliminate them or defer them while preserving their original purpose that would be great too.

npm list

CC @GuillaumeGomez can you explain the purpose of running this in should_run rather than erroring in run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions