rustdoc: Incorrect link to item when the item is reexported and inlined

[SamRodri]

Building the documentation of this code using cargo doc generates a link to the wrong page:

pub mod some {
    pub mod path {
        pub struct Foo;
    }

    #[doc(inline)]
    pub use path::Foo as Bar;
}

/// Link to [`Foo`](crate::some::path::Foo).
pub struct Test;

I expected a link to the some/path/struct.Foo.html page, but got a link to the some/struct.Bar.html page.

Meta

The error happens in the stable 1.51.0 and nightly 2021-04-07 versions.

[jyn514]

I think the issue is that rustdoc tracks URLs by item, not by re-export:

rust/src/librustdoc/html/format.rs

Line 504 in e9cdccc

let (fqp, shortty, mut url) = match cache.paths.get(&did) {

So the URL gets overridden because the re-export and the original item have the same DefId.

[jyn514]

Note this isn't specific to intra-doc links, this also links to Bar:

pub fn f() -> crate::some::path::Foo {
    Foo
}