tidy should stop reporting CRs in a file after a while

[scottmcm]

Because I hadn't cleaned out my workspace, I got a gigantic flood of tidy errors.

Here's a small sample:

tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:883: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:884: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:885: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:886: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:887: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:888: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:889: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:890: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:891: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:892: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:893: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:894: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:895: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:896: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:897: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\ssse3.rs:898: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:1: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:2: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:3: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:4: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:5: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:6: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:7: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:8: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:9: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:10: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:11: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:12: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:13: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:14: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:15: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:16: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:17: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:17: TODO is deprecated; use FIXME
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:18: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:19: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:20: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:21: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:22: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:23: CR character
tidy error: C:\src\rust\src\stdarch\crates\core_arch\src\x86\tbm.rs:24: CR character

It seems like it wouldn't be uncommon for the usual mode here to be for the line endings to be in the wrong order, at which case it failing like this would be expected.

But it's be nice to not get 898 lines of tidy errors for a 898-line file 😆

Maybe it could just stop looking after the first few, or report a count, or...

[tesuji]

Windows loves Linux. How is this possible?

.. it is a joke ?

If you have Windows Subsystem for Linux , dos2unix should help convert CR .

[mati865]

Windows loves Linux. How is this possible?

Git has stupid default setting which converts LF to CRLF on Windows.

If you have Windows Subsystem for Linux , dos2unix should help convert CR .

Or MSYS2.

[jyn514]

Preferably x.py would be able to clean up empty directories that used to be submodules. But this seems like an easy workaround that makes the left-over submodule less annoying.