x.py tidy doesn't ignore untracked files

[arora-aman]

Tidy exists as an external tool that x.py calls, and it has a fixed set of paths that it ignores. Which is unlike other x.py commands which ignore untracked files.

This causes problems when some of the ignored paths get moved. eg: as part of 2c31b45 src/stdarch was moved to library/stdarch.

Error log

tidy error: /users/a52arora/rust/src/stdarch/ci/android-install-ndk.sh:2: copyright notices attributed to the Rust Project Developers are deprecated
tidy error: /users/a52arora/rust/src/stdarch/ci/android-install-sdk.sh:2: copyright notices attributed to the Rust Project Developers are deprecated
tidy error: /users/a52arora/rust/src/stdarch/ci/android-install-sdk.sh:49: line longer than 100 chars
tidy error: /users/a52arora/rust/src/stdarch/ci/android-sysimage.sh:3: copyright notices attributed to the Rust Project Developers are deprecated
tidy error: /users/a52arora/rust/src/stdarch/ci/run.sh:29: tab character
tidy error: /users/a52arora/rust/src/stdarch/ci/run.sh:30: tab character

On one hand I appreciate this, because it tells me to go remove files that aren't required anymore. But on the otherhand I usually run tests in a detached screen session only to come find tests didn't run because of tidy error due to moved submodules.

I'd prefer if the untracked files were ignored and instead at the end of the build log I got a warning saying "Tidy error in untracked directory/file" or someother way of letting me know that a submodule was moved and I should clean up.

[Mark-Simulacrum]

I would be unopposed to not checking untracked files in tidy, and would accept a PR doing so.

Note that you can also run those long-running tests with --exclude src/tools/tidy which should avoid this problem for the time being.

[ollie27]

I would be unopposed to not checking untracked files in tidy, and would accept a PR doing so.

It would be a bit inconvenient to always have to git add new files before running tidy. I usually run tidy first.

[Mark-Simulacrum]

Tidy would still pass though? Just wouldn't give you all the errors, potentially.

[ollie27]

Tidy would still pass though? Just wouldn't give you all the errors, potentially.

The purpose of tidy is to catch errors so if it misses some that's a problem.

[jyn514]

@ollie27 would you be ok with opting-in to check untracked files, maybe in config.toml?