Skip to content

only provide traits like Eq/Ord on @T and @mut T when they're known to be non-cyclic #6553

Closed

Description

Based on #5767.

We should really only be providing these default implementations when we know they're valid.

An easy way of doing it is only implementing them by default on T: Const. It's still possible to make user-defined implementations for types containing non-Const @T, you just can't use deriving and implicitly end up with a faulty implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions