Skip to content

unused_extern_crates: wrong suggestion for aliased crate #57672

Closed
@ehuss

Description

@ehuss

The following suggests converting to a use, but that causes it to fail to compile because use does not insert into the prelude.

#![warn(unused_extern_crates)]

extern crate time as time_crate;  // Suggests replacing with `use`.

pub mod m {
    pub use time_crate::Duration;   // But this will fail to compile.
}

Perhaps the suggestion should be removed if there is a rename?

rustc 1.33.0-nightly (2fadb0a 2019-01-13)
(This is after uniform-paths and the #57557 fix.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-frontendArea: Compiler frontend (errors, parsing and HIR)A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.A-resolveArea: Name/path resolution done by `rustc_resolve` specificallyA-suggestion-diagnosticsArea: Suggestions generated by the compiler applied by `cargo fix`C-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions