Cargo is now compiling examples when executing cargo test

[pietroalbini]

This is probably not going to be reverted, this issue is used to notify crate authors about this.

In Rust 1.27 cargo will start compiling examples when executing cargo test. You (the crates authors) should fix the examples if you want cargo test to continue working.

• mqtt regressed from stable to beta (build log) cc @flier
• uom regressed from stable to beta (build log) cc @iliekturtles

[alexcrichton]

cc @ehuss (just FYI)

[iliekturtles]

Thanks for the heads-up. Looking at the cargobomb log an old version of uom (v0.14.0) is being used. The error shown in the log is fixed in v0.16.0 and the latest release is v0.18.0. Can future cargobomb runs be updated to use the latest version?

[ehuss]

Oh, I didn't consider the situation where someone explicitly listed test = false in Cargo.toml.

To be clear, examples have been built for a long time, but they were skipped when test=false. Now, they are always built, but you can say test=true to make them build and run as a unit test.

I'm trying to think if there's a better solution, but I don't have any ideas. Bins behave the same way (they are still built even if you say test=false). Generally there isn't much control over the default target selection.

Let me know if there's anything I can do.

[pietroalbini]

The error shown in the log is fixed in v0.16.0 and the latest release is v0.18.0. Can future cargobomb runs be updated to use the latest version?

@iliekturtles Crater (cargobomb was the old name) tests multiple versions of some crates, but always the latest one. In the uom case, 0.17.0 was the latest when the crater run started (one takes about 5 days to complete), and it passed. You don't need to worry about that ;)

[alexcrichton]

@ehuss I think given that there's only one regression here and there's no transitive impact I think it's safe to leave as-is.

[pietroalbini]

Closing as won't fix.