-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-trait-systemArea: Trait systemArea: Trait systemC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-langRelevant to the language teamRelevant to the language teamWG-traits[RETIRED] Working group: Traits[RETIRED] Working group: Traits
Description
Now that #47861 has landed, there is a notion of universes for type variables. For now, in order to get #48411 landed, the canonicalization code is simply using UniverseIndex::ROOT
for the universes of type variables it creates (those universes aren't really being used anyway presently).
However, what we ought to be doing is recording (during canonicalization) the universe of the variables that are being fed in. We can then canonicalize those universes (what chalk calls u_canonicalize
) and then recreate them on the other side. And finally we map the universes back.
I'll try to leave more detailed notes later. I expect to either do this or mentor this as follow-up.
cc @sgrif
Metadata
Metadata
Assignees
Labels
A-trait-systemArea: Trait systemArea: Trait systemC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-langRelevant to the language teamRelevant to the language teamWG-traits[RETIRED] Working group: Traits[RETIRED] Working group: Traits