Open
Description
opened on Sep 20, 2017
This commit changed the armv7-linux-androideabi target from generating Arm code to Thumb code. This may be deemed a valid change but I feel like it deserves at least a short discussion for a number of reasons.
- This is a breaking change for anyone that was relying on that target generating Arm code. e.g., anyone using inline assembly with Arm state only instructions or someone bit fiddling code pointers and maybe some other ways. However, I think it's unlikely someone was doing this.
- There is a convention for the rust target names that generate Thumb code to start with
thumb
instead ofarm
. This is the same convention clang uses for--target
and LLVM.
Either way, the same change should probably be applied to all the armv7*
targets for consistency.
Activity