Closed
Description
Recent changes to x.py have stopped it from working when run with Python 3:
[rust] $ python x.py
Updating submodules
Traceback (most recent call last):
File "x.py", line 20, in <module>
bootstrap.main()
File "/home/mjk/Code/rust/src/bootstrap/bootstrap.py", line 684, in main
bootstrap()
File "/home/mjk/Code/rust/src/bootstrap/bootstrap.py", line 662, in bootstrap
rb.update_submodules()
File "/home/mjk/Code/rust/src/bootstrap/bootstrap.py", line 566, in update_submodules
path = line[1:].split(' ')[1]
TypeError: a bytes-like object is required, not 'str'
[rust] $ python --version
Python 3.6.1
[rust] $ git rev-parse HEAD
6af8c6c7d1173f68addbf51560e6a009b30c9a93
It works when run with Python 2.
I had a quick look at fixing it, but it looks like the fix would need testing on Windows (due to console encoding shenanigans) and I don't have a Windows machine available right now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Labels
Relevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.