Skip to content

debuginfo-gdb tests can't handle new gdb that supports rust #36323

Description

@infinity0

Lots of error: line not found in debugger output e.g. see buildlog for 1.13.0~~nightly.20160904, shorter snippet of one failure: https://paste.debian.net/812883/

test result: FAILED. 37 passed; 65 failed; 3 ignored; 0 measured

Activity

  1. added
    A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)
    on Sep 8, 2016
  2. michaelwoerister commented on Sep 8, 2016

    @michaelwoerister
    Member

    @brson @alexcrichton We need test infrastructure that uses a Rust-enabled version of GDB.

    cc @tromey @Manishearth

  3. Manishearth commented on Sep 8, 2016

    @Manishearth
    Member

    set language rust might be necessary in those tests?

  4. alexcrichton commented on Oct 5, 2016

    @alexcrichton
    Member

    Discussed during tools triage today, conclusions were:

    • Ideally tests would support all versions of GDB, perhaps even including a gdb/lldb style split of assertions and commands for newer versions of GDB
    • We should have bots testing both versions of GDB
      • This may involve two bots with two versions of GDB
      • It may also involve one bot testing two versions of GDB
  5. nagisa commented on Nov 3, 2016

    @nagisa
    Member

    This is an example of a failure, which also makes it quite obvious why the tests fail:

    error: line not found in debugger output: $4 = {a = 3, b = 4, c = 5, d = 6, e = 7, f = 8, g = 9, h = 10}
    <snip>
    $4 = function_arg_initialization::BigStruct {a: 3, b: 4, c: 5, d: 6, e: 7, f: 8, g: 9, h: 10}
    

    This is a very nasty failure case because I haven’t seen a successful run of tests on arch for months now.

  6. TimNN commented on Nov 3, 2016

    @TimNN
    Contributor

    I've got a PR ready, which fixes all those tests (for GDB trunk), #37410.

  7. added a commit that references this issue on Nov 4, 2016
  8. added a commit that references this issue on Nov 4, 2016
  9. infinity0 commented on Dec 24, 2016

    @infinity0
    ContributorAuthor

    #37410 was closed, does that mean this is now fixed? It doesn't seem to be in 1.14.0, will it be in 1.15.0?

  10. infinity0 commented on Feb 28, 2017

    @infinity0
    ContributorAuthor

    Ping! Can this be closed? A fix was apparently merged in #37597

  11. michaelwoerister commented on Feb 28, 2017

    @michaelwoerister
    Member

    Yes, I think this can be considered fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions