Use --release-channel=stable by default on releases

[radare]

Release tarballs should be compilable with just basic ./configure ; make ; sudo make install without having to pass special flags to configure. This is the case of the --release-channel option, that must be changed in the releases.

[alexcrichton]

cc @brson, @edunham, this seems like a good idea to me!

[edunham]

I have no objections to this idea.

Please cc me [if|when] a PR adds this feature, since the change may necessitate some minor changes to avoid changing the buildslaves' behavior.

[brson]

I think I'm ok with this, although there's also something to be said for distributing the same source we are building from and this will require flipping a bit somewhere (ofc we're not building from the source tarball at all and basically nobody has any idea whether it even works :).

Off-hand I don't have a smart way to do this. I guess we would need to add some additional metadata to the source directory for the configure script to scrape, or we could frob the configure script with sed when packaging the source tarball.

[alexcrichton]

We could perhaps special case this and say "if .git isn't present we're a source tarball" and just piggy back on that logic.

[brson]

@alexcrichton Yeah, we could. I'm wary though that those may be two distinct cases.

[steveklabnik]

Yeah, I feel vaguely the same re: repeatable builds and such, but @alexcrichton 's suggestion seems reasonable, but possibly footgun-ny...

[radare]

Maybe just check if .git exists?

On 10 Sep 2015, at 01:21, Brian Anderson notifications@github.com wrote:

I think I'm ok with this, although there's also something to be said for distributing the same source we are building from and this will require flipping a bit somewhere (ofc we're not building from the source tarball at all and basically nobody has any idea whether it even works :).

Off-hand I don't have a smart way to do this. I guess we would need to add some additional metadata to the source directory for the configure script to scrape, or we could frob the configure script with sed when packaging the source tarball.

—
Reply to this email directly or view it on GitHub.

[brson]

OK, let's just piggy-back on the .git check.