Skip to content

Consider renaming .connect() to .join() #24645

Closed
@barosl

Description

@barosl

SliceConcatExt has a method named .connect(), which is similar to .join() in other languages. I don't have any specific numbers, but "join" seems to be used more widely.

We could not use "join" because it was previously a keyword. Now it isn't, and SliceConcatExt is currently marked as unstable, so how about renaming the method to a more popular name?

One blocker is that SliceConcatExt is already exported to the prelude. So, although it is technically unstable, the change will still break the currently accepted beta-compatible code.

Will this require a RFC?

cc http://www.reddit.com/r/rust/comments/336rj3/whats_the_best_way_to_join_strings_with_a_space/

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: An issue proposing an enhancement or a PR with one.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions