1.99 beta crater regression: panic when formatting bitflags

log: https://crater-reports.s3.amazonaws.com/beta-1.99-5/1.99.0-beta.1/reg/extended-notify-0.1.3/log.txt
partial reduction:

use enumflags2::bitflags;

#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash)]
#[bitflags]
#[repr(u64)]
pub(crate) enum Interest {
    Established,
    Any,
    Access,
    AccessOpen,
    AccessClose,
    AccessRead,
    AccessOther,
    Create,
    CreateFile,
    CreateFolder,
    CreateOther,
    Modify,
    ModifyData,
    ModifyDataSize,
    ModifyDataContent,
    ModifyDataOther,
    ModifyMetadata,
    ModifyMetadataAccessTime,
    ModifyMetadataWriteTime,
    ModifyMetadataPermissions,
    ModifyMetadataOwnership,
    ModifyMetadataExtended,
    ModifyMetadataOther,
    ModifyRename,
    ModifyRenameTo,
    ModifyRenameFrom,
    ModifyRenameBoth,
    ModifyRenameOther,
    ModifyOther,
    Delete,
    DeleteFile,
    DeleteFolder,
    DeleteOther,
    Other,
}

fn main() {
    let flags = Interest::Established | Interest::Create;
    eprintln!("run step {flags:?}");
}

slightly smaller:

use enumflags2::bitflags;

#[derive(Debug, Clone, Copy)]
#[bitflags]
#[repr(u64)]
pub(crate) enum Interest {
    // we need at least 10 variants to trigger the faulty enum derive(Debug) optimization
    V0,
    V1,
    V2,
    V3,
    V4,
    V5,
    V6,
    V7,
    V8,
    V9,
}

fn main() {
    let flags = Interest::V0 | Interest::V4;
    eprintln!("run step {flags:?}");
}

The problem is that #155452 added a new optimization to derive(Debug) for fieldless enums. But applying #[bitflags] rewrites the enum and gives it discriminants, making the generated Debug code incorrect.
Essentially this is yet another instance of #148423.

We discussed this in the libs meeting - we'd like to revert this and backport the revert, yeah. If there's a way to do this opt without breaking bitflags, we could try to re-land a version of this on nightly. Thanks for bringing this up!

Revert "Implement Debug for C-like enums with a concatenated string"

Rollup merge of rust-lang#162164 - nnethercote:revert-concat-Debug, r…

We discussed this in the lang call today. We're happy with the revert here.

Rollup merge of rust-lang#162164 - nnethercote:revert-concat-Debug, r…

Unrolled build for #162164 in rollup 162229

Revert "Implement Debug for C-like enums with a concatenated string"

If there's a way to do this opt without breaking bitflags, we could try to re-land a version of this on nightly. Thanks for bringing this up!

I think we could do a version with a match that maps variant to a variant index, instead of reading discriminant_value. This wouldn't avoid the match statement overhead, but it would avoid the MIR and binary size overhead from string constant in each arm (which I think was more significant part of the overhead motivating this optimization).

Navigation Menu

Repository navigation

1.99 beta crater regression: panic when formatting bitflags #162124

13 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

1.99 beta crater regression: panic when formatting bitflags #162124

Description

Activity

cyrgani commented on Sep 1, 2026

13 remaining items

nia-e commented on Sep 1, 2026

traviscross commented on Sep 2, 2026

panstromek commented on Sep 4, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions