Tracking Issue for `cmp_splat` (Variadic `min` and `max`)

[bushrat011899]

Feature gate: #![feature(cmp_splat)]
Zulip: #t-libs-api/api-changes > variadic min/max

This is a tracking issue for variadic cmp::min and cmp::max functions. Currently, these are separate functions named smallest and largest. To allow variadic support, #![feature(splat)] is enabled in core. See #153629 for further details.

Public API

// core::cmp

// Private implementation detail
impl(self) const trait TupleReduce: Tuple {
    type Item;
    fn reduce<F: [const] Destruct + [const] FnMut(Self::Item, Self::Item) -> Self::Item>(self, f: F) -> Self::Item;
}

impl<T> TupleReduce for (T, ...) { /* ... */ }

#[must_use]
pub const fn smallest<T: [const] Ord + [const] Destruct>(
    #[rustc_splat] vals: impl [const] TupleReduce<Item = T>,
) -> T;

#[must_use]
pub const fn largest<T: [const] Ord + [const] Destruct>(
    #[rustc_splat] vals: impl [const] TupleReduce<Item = T>,
) -> T;

Note that with #[rustc_splat], the signature of smallest and largest is any of fn(T) -> T through to fn(T, T, ..) -> T (up to twelve arguments). Twelve has been chosen as an arbitrary limit and can be changed.

Steps / History

(Remember to update the S-tracking-* label when checking boxes.)

• ACP: ACP: Variadic core::cmp::{min, max} libs-team#848
• Implementation: Experiment: Add core::cmp::smallest and core::cmp::largest #160687
• Final comment period (FCP)¹
• Stabilization PR

Unresolved Questions

• Should we replace min and max (and their _by(_key) alternatives), or offer these new functions under a separate name?

Footnotes

1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html ↩