Confusing "This impl block contains no items." with non-public functions

[DanielEScherzer]

Code

rust/library/core/src/ops/control_flow.rs

Lines 425 to 446 in 7f99507

	/// These are used only as part of implementing the iterator adapters.
	/// They have mediocre names and non-obvious semantics, so aren't
	/// currently on a path to potential stabilization.
	impl<R: ops::Try> ControlFlow<R, R::Output> {
	/// Creates a `ControlFlow` from any type implementing `Try`.
	#[inline]
	pub(crate) fn from_try(r: R) -> Self {
	match R::branch(r) {
	ControlFlow::Continue(v) => ControlFlow::Continue(v),
	ControlFlow::Break(v) => ControlFlow::Break(R::from_residual(v)),
	}
	}
	/// Converts a `ControlFlow` into any type implementing `Try`.
	#[inline]
	pub(crate) fn into_try(self) -> R {
	match self {
	ControlFlow::Continue(v) => R::from_output(v),
	ControlFlow::Break(v) => v,
	}
	}
	}

Reproduction Steps

However the docs on doc.rust-lang.org are built - linking to 1.93.1 version of the reference but present on the latest nightly

Expected Outcome

Perhaps something like (bolding add to indicate change)

This impl block contains no public items.

Actual Output

See https://doc.rust-lang.org/1.93.1/std/ops/enum.ControlFlow.html#impl-ControlFlow%3CR,+%3CR+as+Try%3E::Output%3E - includes a note

This impl block contains no items.

but if you look at the source there are items, they are just pub(crate) which I assume is why they are not shown

Version

rustdoc 1.93.1 (01f6ddf75 2026-02-11)

[eggyal]

I don't think rustdoc should show the impl block at all if nothing within it is to be rendered.

@rustbot label +A-docs +A-rustdoc-ui +A-visibility -needs-triage

[DanielEScherzer]

I don't think rustdoc should show the impl block at all if nothing within it is to be rendered.

Having looked through the history a bit - the impl block is shown because there is documentation, #90905

[eggyal]

Ah, okay. Then in this case I suspect the doc comment on the impl should just (in addition to adding "public" to the note as suggested in the OP?) be changed to a normal comment.

@rustbot label +E-easy

[DanielEScherzer]

Okay, I sent #152877 to fix this specific case, but just because it gets fixed for ControlFlow doesn't mean that this isn't an issue for other documentation blocks

[eggyal]

I don't see a problem with changing the note to say "...public items".

rust/src/librustdoc/html/render/mod.rs

Line 2347 in ef70767

<div class=\"stab empty-impl\">This impl block contains no items.</div>\

[eggyal]

Actually, if one is documenting private items and the impl is still empty, then "public items" would be incorrect. So it perhaps needs a bit more logic to it than a simple edit.