Skip to content

Tracking issue for release notes of #149273: Don't leak sysroot crates through dependencies #150531

Closed as not planned
Closed as not planned
Tracking issue for release notes of #149273: Don't leak sysroot crates through dependencies#150531
Labels
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.relnotesMarks issues that should be documented in the release notes of the next release.relnotes-tracking-issueMarks issues tracking what text to put in release notes.
Milestone
1.94.0

Description

@rustbot
rustbot
opened on Dec 31, 2025

This issue tracks the release notes text for #149273.

cc @bjorn3, @petrochenkov -- original issue/PR authors and assignees for drafting text

See the forge.rust-lang.org chapter about release notes for an overview of how the release team makes use of these tracking issues.

Release notes text

This section should be edited to specify the correct category(s) for the change, with succinct description(s) of what changed. Some things worth considering:

  • Does this need an additional compat notes section?
  • Was this a libs stabilization that should have additional headers to list new APIs under Stabilized APIs and Const Stabilized APIs?
# Compatibility Notes
- [Don't leak sysroot crates through dependencies](https://github.com/rust-lang/rust/pull/149273)

Tip

Use the previous releases for inspiration on how to write the release notes text and which categories to pick.

Release blog section

If this change is notable enough for inclusion in the blog post then this section should be edited to contain a draft for the blog post. Otherwise leave it empty.



Note


If a blog post section is required the release-blog-post label should be added (@rustbot label +release-blog-post) to this issue as otherwise it may be missed by the release team.


Activity
  1. rustbot
    added this to the  1.94.0 milestone on Dec 31, 2025
  2. rustbot
    added 
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
     
    relnotesMarks issues that should be documented in the release notes of the next release.
     
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
     
    A-run-makeArea: port run-make Makefiles to rmake.rs
     
    relnotes-tracking-issueMarks issues tracking what text to put in release notes.
     
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
     on Dec 31, 2025
  3. jieyouxu commented on Dec 31, 2025 
    @jieyouxu
    jieyouxu
    on Dec 31, 2025
    Member
    From what I can understand, the compat notes here might be something like
    

    

    Previously there are situations where when there are multiple crate loading candidates with distinct metadata for the same crate name, we unintentionally picked a resolution even though an ambiguity error should be reported. This is now fixed in #149273.
    

    

    cc @petrochenkov @bjorn3 does that description seem accurate to you?
  4. jieyouxu
    added 
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
     and removed 
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
     
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
     
    A-run-makeArea: port run-make Makefiles to rmake.rs
     on Dec 31, 2025
  5. bjorn3 commented on Dec 31, 2025 
    @bjorn3
    bjorn3
    on Dec 31, 2025
    Member
    I think this change is not observable on stable. We already handled everything correctly for --extern dependencies and the sysroot doesn't contain duplicates for any non-rustc_private crate.
  6. jieyouxu commented on Dec 31, 2025 
    @jieyouxu
    jieyouxu
    on Dec 31, 2025
    Member
    Ah. Maybe I'm just misunderstanding 👍
    

    EDIT: context was #t-release > Crater runs for 1.93 #149833 @ 💬
  7. jieyouxu
    closed this as not plannedon Dec 31, 2025
  8. jieyouxu
    removed 
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
     on Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Metadata
Assignees
No one assigned
    Labels
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.relnotesMarks issues that should be documented in the release notes of the next release.relnotes-tracking-issueMarks issues tracking what text to put in release notes.
    Type
    No type
    Projects
    No projects
      Milestone
      Relationships
      None yet
      Development
      No branches or pull requests
      Issue actions