Skip to content

sys::thread_local::key::tests::destructors fails under x86 Windows 7 #141300

Open
@PaulDance

Description

@PaulDance

Code

Running the sys::thread_local::key::tests::destructors test under x86 Windows 7 (i686-win7-windows-msvc) currently fails with the following error:

thread 'sys::thread_local::key::tests::destructors' panicked at library/std/src/sys/thread_local/key/tests.rs:57:5:
assertion `left == right` failed: destructor should have dropped the other reference on thread exit
  left: 2
 right: 1

Version it worked on

The test does not fail when using dev @ 3c5aef3, or a7c39b6 if only considering first-parent master merge commits.

Version with regression

It starts to fail with the following 67a97ba commit of the same 077cedc rollup. It still fails more recently with 2b96ddc.

This is therefore definitely caused by #140007. That makes sense considering there hasn't been much other changes to the target recently. However, it is concerning because the target should still have emulated TLS, as intended by the PR "at fault". There could thus be a problem with the TLS emulation itself.

@rustbot label A-atomic A-thread-locals A-destructors A-testsuite O-x86_32 O-windows-7 O-windows-msvc

@rustbot modify labels: +regression-from-stable-to-beta -regression-untriaged

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-atomicArea: Atomics, barriers, and sync primitivesA-destructorsArea: Destructors (`Drop`, …)A-testsuiteArea: The testsuite used to check the correctness of rustcA-thread-localsArea: Thread local storage (TLS)C-bugCategory: This is a bug.O-windows-7OS: Windows 7 or Windows Server 2008 R2 or etc.O-windows-msvcToolchain: MSVC, Operating system: WindowsO-x86_32Target: x86 processors, 32 bit (like i686-*) (IA-32)P-lowLow priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions