Skip to content

PathSet prefix matching breaks cli path filter consumption order #135022

Closed
@jieyouxu

Description

@jieyouxu

#133492 changed PathSet matching to also admit path prefixes, in addition to the previously-admitted suffixes. Unfortunately, this breaks how describe! handles some Steps. For the typical non-ShouldRun::suite_path Step, it will consume a path filter like "compiler" when eligible.

#133492 allowing prefix matching changed which Steps is permitted to "eat" the path filter first, which broke ./x test compiler --stage 0 and ./x build compiler --stage 0 due to the respective Step registration order and which Steps get to consume the path filter first:

cc discussions at https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Mismatch.20between.20arg-filter.20vs.20.60--exclude.60.20filter.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions