Skip to content

Investigate if stamp logic in bootstrap could be consistently handled #134962

Open
@jieyouxu

Description

We were looking to revisit the tool_check_step! macro in check logic in #134950, but found that stamp logic was scattered. Different check steps (and probably other step kinds) might not have their stamp logic be consistently handled if only one stamp logic site is changed but not the others.

Change of stamp looks sus: the same stamps build in

.join(format!(".{}-check.stamp", stringify!($name).to_lowercase()));
too, but now they desync. I think it's simpler to revert it in current pr (and optionally rework stamps in separate pr, so they can be produces somehow centralized).

Originally posted by @klensy in #134950 (comment)

Might be valuable to double-check how stamps are handled throughout bootstrap, and possibly unify the stamp handling logic so they don't risk diverging.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A-bootstrap-stampArea: bootstrap stamp logicC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-needs-investigationCall for partcipation: This issues needs some investigation to determine current statusT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions