Skip to content

Deny special FileCheck prefixes being used as revision names. #130982

Open

Description

FileCheck expects directives like:

// COM:
// CHECK:
// CHECK-NEXT:
// CHECK-SAME:
// CHECK-EMPTY:
// CHECK-NOT:
// CHECK-COUNT:
// CHECK-DAG:
// CHECK-LABEL:

compiletest supports //@ revisions: a b c and passes the revision names as --check-prefixes=a,b,c to FileCheck. They look like

// a:
// b-NOT:
// c-SAME:

However, FileCheck has special default/reserved prefixes like CHECK or COM, and if the test writer uses those as revision names, it becomes really confusing: //@ revisions: CHECK COM. We should deny those.

Also we should deny NEXT, SAME, EMPTY, NOT, COUNT, DAG and LABEL, because

// next:
// same-SAME:
// not-NOT:

is equally confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerC-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions