Skip to content

Outdated master branch detection doesn't work with worktrees #130111

Closed

Description

When running any bootstrap command, it complains that it can't figure out whether my master branch is outdated.
Of course it does, as it just YOLOs into .git, which is just a file and not a directory for worktrees:

let branch_path = git_dir.join(".git/refs/remotes").join(&updated_master);

it should probably not do that (i don't have a suggestion on what to do instead)

regressed by #129584 @lolbinarycat @albertlarsan68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions