Skip to content

pre-commit hook for ./x.py fmt appears to not always know which files were changed. #125287

Open
@zachs18

Description

@zachs18

I tried this PR: #125283 (original push was just the first two commits, which have invalid formatting)

I expected to see this happen: git push pre-commit-hook should have noticed that the formatting for library/alloc/src/sync.rs was invalid in the pre-commit hook.

Instead, this happened: The push completed successfully.

I haven't been able to reproduce the issue (intentionally trying to push code with invalid formatting is caught by the pre-commit-hook in the times I've tried since).

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.S-needs-reproStatus: This issue has no reproduction and needs a reproduction to make progress.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions