Skip to content

Port backtrace-rs test-crates to rustc repo #122899

Open
@workingjubilee

Description

backtrace-rs has a number of subcrates which it uses to test more complicated logic that is harder to observe from inside a program, leading to this exciting yaml: https://github.com/rust-lang/backtrace-rs/blob/6fa4b85b9962c3e1be8c2e5cc605cd078134152b/.github/workflows/main.yml#L54-L69

while tests inside backtrace's library itself will be run as part of the stdlib's test suite, these are not. backtrace-rs failed to run nightly testing for Windows, which would have caught this. however, many of these tests are directly relevant to rustc's functionality as well, and changes should not be landed in rustc which break them without very good reason. failing to include these tests led to a severe regression in backtraces on Windows. these tests should be ported to run inside rustc's existing test infrastructure where they are relevant. I have excepted one which was already based on a rustc test and one which is only relevant for backtrace-rs.

if you would like to work on porting one of these tests, please link to this issue in your PR and leave a comment to claim the test. if you are stuck, please don't hesitate to open a thread on the rust zulip! and be aware, some may be complex enough to need the new recipes infrastructure, but hopefully not. I expect all may need, however, this compiletest annotation:

//@ needs-unwind

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    A-backtraceArea: BacktracesA-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.E-help-wantedCall for participation: Help is requested to fix this issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions