Skip to content

x clippy keeps nix-patching binaries #119442

Closed
@Noratrieb

Description

@Noratrieb

On NixOS, when executing x clippy for the first time, clippy is downloaded and patched for nix. But every time I run x clippy after that, it still patches it.

nils@nixos ~/p/rust (master)> x clippy compiler -Aclippy::all -Dclippy::correctness
Building bootstrap
    Finished dev [unoptimized] target(s) in 0.04s

INFO: You seem to be using Nix.
attempting to patch /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0/bin/cargo-clippy
attempting to patch /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0/bin/clippy-driver
INFO: You seem to be using Nix.
attempting to patch /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0/bin/cargo-clippy
attempting to patch /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0/bin/clippy-driver
extracting /home/nils/projects/rust/build/cache/2023-12-22/clippy-beta-x86_64-unknown-linux-gnu.tar.xz to /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0
INFO: You seem to be using Nix.
attempting to patch /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0/bin/cargo-clippy
attempting to patch /home/nils/projects/rust/build/x86_64-unknown-linux-gnu/stage0/bin/clippy-driver
Checking stage0 library artifacts (x86_64-unknown-linux-gnu)

To reproduce: Be on NixOS (or patch bootstrap so that should_fix_bins_and_dylibs return true). Run x clippy several times.

Metadata

Metadata

Assignees

Labels

C-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions