Skip to content

default binary size increase due to ice dumps logic #115610

Closed
@oli-obk

Description

@oli-obk

#108714 slightly increased default binary size (checked on x86_64-pc-windows-msvc), the reason is now code

if let Some(path) = path
&& let Ok(mut out) = crate::fs::File::options().create(true).append(true).open(&path)
{
write(&mut out, BacktraceStyle::full());
}
unconditionally includes File::open (~ 2kb out of 130) and friends. can be tracked back by new imports of CreateFileW, GetFullPathNameW for rustc empty.rs -Copt-level=3 -Cdebuginfo=0 -Clto=yes -Ccodegen-units=1 -Cpanic=abort --edition=2018 where empty.rs is fn main(){}

Originally posted by @klensy in #108714 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-panicArea: Panicking machineryI-heavyIssue: Problems and improvements with respect to binary size of generated code.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions