Closed
Description
This code should be fine, and Miri actually runs it without any complaint
#![feature(custom_mir, core_intrinsics)]
extern crate core;
use core::intrinsics::mir::*;
#[custom_mir(dialect = "runtime", phase = "optimized")]
pub fn fn0() {
mir! {
let x: i32;
let tuple: (*mut i32,);
{
tuple.0 = core::ptr::addr_of_mut!(x);
*(tuple.0) = 1;
Return()
}
}
}
pub fn main() {
fn0();
}But it fails MIR validation
% rustc repro.rs
error: internal compiler error: no errors encountered even though `delay_span_bug` issued
error: internal compiler error: broken MIR in Item(WithOptConstParam { did: DefId(0:5 ~ repro[e1bb]::fn0), const_param_did: None }) (after phase change to runtime-optimized) at bb0[1]:
(*(_2.0: *mut i32)), has deref at the wrong place
--> repro.rs:11:13
|
11 | *(tuple.0) = 1;
| ^^^^^^^^^^^^^^
|
= note: delayed at 0: std::backtrace::Backtrace::create
1: <rustc_errors::HandlerInner>::emit_diagnostic
2: <rustc_errors::Handler>::delay_span_bug::<rustc_span::span_encoding::Span, &alloc::string::String>
3: <rustc_const_eval::transform::validate::TypeChecker>::fail::<alloc::string::String>
4: <rustc_const_eval::transform::validate::TypeChecker as rustc_middle::mir::visit::Visitor>::visit_place
5: <rustc_const_eval::transform::validate::TypeChecker as rustc_middle::mir::visit::Visitor>::visit_statement
6: <rustc_const_eval::transform::validate::Validator as rustc_middle::mir::MirPass>::run_pass
7: rustc_mir_transform::pass_manager::run_passes_inner
8: rustc_mir_transform::optimized_mir
9: rustc_query_system::query::plumbing::try_execute_query::<rustc_query_impl::queries::optimized_mir, rustc_query_impl::plumbing::QueryCtxt>
10: <rustc_query_impl::Queries as rustc_middle::ty::query::QueryEngine>::optimized_mir
11: <rustc_middle::ty::context::TyCtxt>::instance_mir
12: rustc_monomorphize::collector::collect_neighbours
13: rustc_monomorphize::collector::collect_items_rec
14: rustc_monomorphize::collector::collect_items_rec
15: <core::panic::unwind_safe::AssertUnwindSafe<rustc_data_structures::sync::par_for_each_in<alloc::vec::Vec<rustc_middle::mir::mono::MonoItem>, rustc_monomorphize::collector::collect_crate_mono_items::{closure#1}::{closure#0}>::{closure#0}::{closure#0}> as core::ops::function::FnOnce<()>>::call_once
16: rustc_data_structures::sync::par_for_each_in::<alloc::vec::Vec<rustc_middle::mir::mono::MonoItem>, rustc_monomorphize::collector::collect_crate_mono_items::{closure#1}::{closure#0}>
17: <rustc_session::session::Session>::time::<(), rustc_monomorphize::collector::collect_crate_mono_items::{closure#1}>
18: rustc_monomorphize::collector::collect_crate_mono_items
19: rustc_monomorphize::partitioning::collect_and_partition_mono_items
20: rustc_query_system::query::plumbing::try_execute_query::<rustc_query_impl::queries::collect_and_partition_mono_items, rustc_query_impl::plumbing::QueryCtxt>
21: <rustc_query_impl::Queries as rustc_middle::ty::query::QueryEngine>::collect_and_partition_mono_items
22: rustc_codegen_ssa::base::codegen_crate::<rustc_codegen_llvm::LlvmCodegenBackend>
23: <rustc_codegen_llvm::LlvmCodegenBackend as rustc_codegen_ssa::traits::backend::CodegenBackend>::codegen_crate
24: <rustc_session::session::Session>::time::<alloc::boxed::Box<dyn core::any::Any>, rustc_interface::passes::start_codegen::{closure#0}>
25: rustc_interface::passes::start_codegen
26: <rustc_middle::ty::context::GlobalCtxt>::enter::<<rustc_interface::queries::Queries>::ongoing_codegen::{closure#0}::{closure#0}, core::result::Result<alloc::boxed::Box<dyn core::any::Any>, rustc_span::ErrorGuaranteed>>
27: <rustc_interface::queries::Queries>::ongoing_codegen
28: <rustc_interface::interface::Compiler>::enter::<rustc_driver_impl::run_compiler::{closure#1}::{closure#2}, core::result::Result<core::option::Option<rustc_interface::queries::Linker>, rustc_span::ErrorGuaranteed>>
29: rustc_span::set_source_map::<core::result::Result<(), rustc_span::ErrorGuaranteed>, rustc_interface::interface::run_compiler<core::result::Result<(), rustc_span::ErrorGuaranteed>, rustc_driver_impl::run_compiler::{closure#1}>::{closure#0}::{closure#0}>
30: <scoped_tls::ScopedKey<rustc_span::SessionGlobals>>::set::<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_span::ErrorGuaranteed>, rustc_driver_impl::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_span::ErrorGuaranteed>>
31: std::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_span::ErrorGuaranteed>, rustc_driver_impl::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_span::ErrorGuaranteed>>::{closure#0}::{closure#0}, core::result::Result<(), rustc_span::ErrorGuaranteed>>
32: <<std::thread::Builder>::spawn_unchecked_<rustc_interface::util::run_in_thread_pool_with_globals<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_span::ErrorGuaranteed>, rustc_driver_impl::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_span::ErrorGuaranteed>>::{closure#0}::{closure#0}, core::result::Result<(), rustc_span::ErrorGuaranteed>>::{closure#1} as core::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
33: std::sys::unix::thread::Thread::new::thread_start
34: __pthread_joiner_wake
note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
note: rustc 1.70.0-nightly (9df3a39fb 2023-04-11) running on aarch64-apple-darwin
query stack during panic:
end of query stack
Custom MIR translation looks right
% rustc -Zunpretty=mir repro.rs
// WARNING: This output format is intended for human consumers only
// and is subject to change without notice. Knock yourself out.
fn fn0() -> () {
let mut _0: (); // return place in scope 0 at repro.rs:5:14: 5:14
let mut _1: i32; // in scope 0 at /rustc/9df3a39fb30575d808e70800f9fad5362aac57a2/library/core/src/intrinsics/mir.rs:390:21: 390:32
let mut _2: (*mut i32,); // in scope 0 at /rustc/9df3a39fb30575d808e70800f9fad5362aac57a2/library/core/src/intrinsics/mir.rs:390:21: 390:32
bb0: {
(_2.0: *mut i32) = &raw mut _1; // scope 0 at repro.rs:10:13: 10:49
(*(_2.0: *mut i32)) = const 1_i32; // scope 0 at repro.rs:11:13: 11:27
return; // scope 0 at repro.rs:12:13: 12:21
}
}
fn main() -> () {
let mut _0: (); // return place in scope 0 at repro.rs:16:15: 16:15
let _1: (); // in scope 0 at repro.rs:17:5: 17:10
bb0: {
_1 = fn0() -> bb1; // scope 0 at repro.rs:17:5: 17:10
// mir::Constant
// + span: repro.rs:17:5: 17:8
// + literal: Const { ty: fn() {fn0}, val: Value(<ZST>) }
}
bb1: {
return; // scope 0 at repro.rs:18:2: 18:2
}
}
Meta
rustc --version --verbose:
rustc 1.70.0-nightly (9df3a39fb 2023-04-11)
binary: rustc
commit-hash: 9df3a39fb30575d808e70800f9fad5362aac57a2
commit-date: 2023-04-11
host: aarch64-apple-darwin
release: 1.70.0-nightly
LLVM version: 16.0.2