Skip to content

Run tests for dist builds #109535

Closed
Closed
@Noratrieb

Description

@Noratrieb

We currently run tests for stage 1 and stage 2 builds (I think). So these are guaranteed to pass on tier 1 targets.

But on some targets like x86_64-unknown-linux-gnu we don't ship stage 2 builds, we ship special PGO/BOLT builds that have more optimizations. As we have recently found out in #109067 and #108978, these extra optimizations can lead to miscompilations. We currently have no way to detect this except for users on nightly (or stable as in this case) to see weird behavior. That's very bad.

To do our best to prevent dist miscompilations from shipping, we should find a way to run tests for dist toolchains on targets where extra optimizations are applied.

The dist-x86_64-linux builder is currently one of the slowest builders and running tests in there takes extra time, which would slow down our CI. Ideally we'd find a way to run these tests without impacting CI performance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustcT-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions