Could not find `__OsLocalKeyInner` in `thread` when running cargo install

[SumiGovindaraju]

I tried this code:

cargo install cargo-binutils

The installation of this crate should work, but instead I run into this error (I also see the same error when trying to build other personal repositories):

Console Output

    Updating crates.io index
  Installing cargo-binutils v0.3.6
   Compiling proc-macro2 v1.0.46
   Compiling unicode-ident v1.0.4
   Compiling quote v1.0.21
   Compiling syn v1.0.101
   Compiling serde_derive v1.0.145
   Compiling serde v1.0.145
   Compiling memchr v2.5.0
   Compiling libc v0.2.134
   Compiling cc v1.0.73
   Compiling adler v1.0.2
   Compiling semver v1.0.14
   Compiling failure_derive v0.1.8
   Compiling unicode-xid v0.2.4
   Compiling gimli v0.26.2
   Compiling miniz_oxide v0.5.4
   Compiling rustc-demangle v0.1.21
   Compiling camino v1.1.1
   Compiling object v0.29.0
   Compiling backtrace v0.3.66
   Compiling cfg-if v1.0.0
   Compiling serde_json v1.0.85
   Compiling unicode-width v0.1.10
   Compiling itoa v1.0.3
   Compiling ryu v1.0.11
   Compiling anyhow v1.0.65
   Compiling textwrap v0.11.0
   Compiling atty v0.2.14
   Compiling aho-corasick v0.7.19
   Compiling vec_map v0.8.2
   Compiling strsim v0.8.0
   Compiling bitflags v1.3.2
   Compiling regex-syntax v0.6.27
   Compiling ansi_term v0.12.1
   Compiling clap v2.34.0
   Compiling addr2line v0.17.0
   Compiling synstructure v0.12.6
   Compiling regex v1.6.0
error[E0433]: failed to resolve: could not find `__OsLocalKeyInner` in `thread`
   --> /Users/sumukhgovindaraju/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.66/src/lib.rs:163:5
    |
163 |     thread_local!(static LOCK_HELD: Cell<bool> = Cell::new(false));
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `__OsLocalKeyInner` in `thread`
    |
    = note: this error originates in the macro `$crate::__thread_local_inner` which comes from the expansion of the macro `thread_local` (in Nightly builds, run with -Z macro-backtrace for more info)

WARN rustc_errors::emitter Invalid span /rustc/8ce3204af9463db3192ea1eb31c45c2f6d4b5ae6/library/std/src/thread/local.rs:338:47: 338:64 (#147), error=SourceNotAvailable { filename: Real(Remapped { local_path: None, virtual_name: "/rustc/8ce3204af9463db3192ea1eb31c45c2f6d4b5ae6/library/std/src/thread/local.rs" }) }
error[E0412]: cannot find type `__OsLocalKeyInner` in module `$crate::thread`
   --> /Users/sumukhgovindaraju/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.66/src/lib.rs:163:5
    |
163 |     thread_local!(static LOCK_HELD: Cell<bool> = Cell::new(false));
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a struct with a similar name exists: `__FastLocalKeyInner`
    |
    = note: this error originates in the macro `$crate::__thread_local_inner` which comes from the expansion of the macro `thread_local` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0433]: failed to resolve: could not find `__OsLocalKeyInner` in `thread`
  --> /Users/sumukhgovindaraju/.cargo/registry/src/github.com-1ecc6299db9ec823/regex-1.6.0/src/pool.rs:67:1
   |
67 | / thread_local!(
68 | |     /// A thread local used to assign an ID to a thread.
69 | |     static THREAD_ID: usize = {
70 | |         let next = COUNTER.fetch_add(1, Ordering::Relaxed);
...  |
84 | |     };
85 | | );
   | |_^ could not find `__OsLocalKeyInner` in `thread`
   |
   = note: this error originates in the macro `$crate::__thread_local_inner` which comes from the expansion of the macro `thread_local` (in Nightly builds, run with -Z macro-backtrace for more info)

WARN rustc_errors::emitter Invalid span /rustc/8ce3204af9463db3192ea1eb31c45c2f6d4b5ae6/library/std/src/thread/local.rs:338:47: 338:64 (#472), error=SourceNotAvailable { filename: Real(Remapped { local_path: None, virtual_name: "/rustc/8ce3204af9463db3192ea1eb31c45c2f6d4b5ae6/library/std/src/thread/local.rs" }) }
error[E0412]: cannot find type `__OsLocalKeyInner` in module `$crate::thread`
  --> /Users/sumukhgovindaraju/.cargo/registry/src/github.com-1ecc6299db9ec823/regex-1.6.0/src/pool.rs:67:1
   |
67 | / thread_local!(
68 | |     /// A thread local used to assign an ID to a thread.
69 | |     static THREAD_ID: usize = {
70 | |         let next = COUNTER.fetch_add(1, Ordering::Relaxed);
...  |
84 | |     };
85 | | );
   | |_^ help: a struct with a similar name exists: `__FastLocalKeyInner`
   |
   = note: this error originates in the macro `$crate::__thread_local_inner` which comes from the expansion of the macro `thread_local` (in Nightly builds, run with -Z macro-backtrace for more info)

Some errors have detailed explanations: E0412, E0433.
For more information about an error, try `rustc --explain E0412`.
error: could not compile `backtrace` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `regex` due to 2 previous errors
error: failed to compile `cargo-binutils v0.3.6`, intermediate artifacts can be found at `/var/folders/jg/pgt0p9hj0cv0pk6fq9g4wjb40000gn/T/cargo-installLNnPUU`

Meta

rustc --version --verbose:

rustc 1.66.0-nightly (8ce3204af 2022-09-30)
binary: rustc
commit-hash: 8ce3204af9463db3192ea1eb31c45c2f6d4b5ae6
commit-date: 2022-09-30
host: aarch64-apple-darwin
release: 1.66.0-nightly
LLVM version: 15.0.2

Backtrace

    Updating crates.io index
  Installing cargo-binutils v0.3.6
   Compiling proc-macro2 v1.0.46
   Compiling unicode-ident v1.0.4
   Compiling quote v1.0.21
   Compiling syn v1.0.101
   Compiling serde_derive v1.0.145
   Compiling serde v1.0.145
   Compiling memchr v2.5.0
   Compiling libc v0.2.134
   Compiling cc v1.0.73
   Compiling adler v1.0.2
   Compiling unicode-xid v0.2.4
   Compiling semver v1.0.14
   Compiling gimli v0.26.2
   Compiling failure_derive v0.1.8
   Compiling miniz_oxide v0.5.4
   Compiling cfg-if v1.0.0
   Compiling camino v1.1.1
   Compiling serde_json v1.0.85
   Compiling backtrace v0.3.66
   Compiling object v0.29.0
   Compiling rustc-demangle v0.1.21
   Compiling itoa v1.0.3
   Compiling ryu v1.0.11
   Compiling unicode-width v0.1.10
   Compiling anyhow v1.0.65
   Compiling textwrap v0.11.0
   Compiling atty v0.2.14
   Compiling aho-corasick v0.7.19
   Compiling vec_map v0.8.2
   Compiling regex-syntax v0.6.27
   Compiling strsim v0.8.0
   Compiling ansi_term v0.12.1
   Compiling addr2line v0.17.0
   Compiling bitflags v1.3.2
   Compiling clap v2.34.0
   Compiling synstructure v0.12.6
   Compiling regex v1.6.0
error[E0433]: failed to resolve: could not find `__OsLocalKeyInner` in `thread`
   |
  ::: /Users/sumukhgovindaraju/.cargo/registry/src/github.com-1ecc6299db9ec823/regex-1.6.0/src/pool.rs:67:1
   |
67 | / thread_local!(
68 | |     /// A thread local used to assign an ID to a thread.
69 | |     static THREAD_ID: usize = {
70 | |         let next = COUNTER.fetch_add(1, Ordering::Relaxed);
...  |
84 | |     };
85 | | );
   | |_- in this macro invocation (#1)

WARN rustc_errors::emitter Invalid span /rustc/8ce3204af9463db3192ea1eb31c45c2f6d4b5ae6/library/std/src/thread/local.rs:338:47: 338:64 (#472), error=SourceNotAvailable { filename: Real(Remapped { local_path: None, virtual_name: "/rustc/8ce3204af9463db3192ea1eb31c45c2f6d4b5ae6/library/std/src/thread/local.rs" }) }
error[E0412]: cannot find type `__OsLocalKeyInner` in module `$crate::thread`
   |
  ::: /Users/sumukhgovindaraju/.cargo/registry/src/github.com-1ecc6299db9ec823/regex-1.6.0/src/pool.rs:67:1
   |
67 | / thread_local!(
68 | |     /// A thread local used to assign an ID to a thread.
69 | |     static THREAD_ID: usize = {
70 | |         let next = COUNTER.fetch_add(1, Ordering::Relaxed);
...  |
84 | |     };
85 | | );
   | |_- in this macro invocation (#1)

Some errors have detailed explanations: E0412, E0433.
For more information about an error, try `rustc --explain E0412`.
error: could not compile `regex` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error[E0433]: failed to resolve: could not find `__OsLocalKeyInner` in `thread`
    |
   ::: /Users/sumukhgovindaraju/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.66/src/lib.rs:163:5
    |
163 |     thread_local!(static LOCK_HELD: Cell<bool> = Cell::new(false));
    |     -------------------------------------------------------------- in this macro invocation (#1)

WARN rustc_errors::emitter Invalid span /rustc/8ce3204af9463db3192ea1eb31c45c2f6d4b5ae6/library/std/src/thread/local.rs:338:47: 338:64 (#147), error=SourceNotAvailable { filename: Real(Remapped { local_path: None, virtual_name: "/rustc/8ce3204af9463db3192ea1eb31c45c2f6d4b5ae6/library/std/src/thread/local.rs" }) }
error[E0412]: cannot find type `__OsLocalKeyInner` in module `$crate::thread`
    |
   ::: /Users/sumukhgovindaraju/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.66/src/lib.rs:163:5
    |
163 |     thread_local!(static LOCK_HELD: Cell<bool> = Cell::new(false));
    |     -------------------------------------------------------------- in this macro invocation (#1)

error: could not compile `backtrace` due to 2 previous errors
error: failed to compile `cargo-binutils v0.3.6`, intermediate artifacts can be found at `/var/folders/jg/pgt0p9hj0cv0pk6fq9g4wjb40000gn/T/cargo-installqHa6cL`

Thanks for looking into this! Any help is appreciated.

[RalfJung]

This looks like it might be related to #100201. But given that CI passed that change in general seems to work, and it has landed 6 weeks ago without exploding the world, so the question is why it would fail only for you?

If you just try to build this as a crate with no dependencies, does that work?

use std::cell::Cell;

thread_local!(static LOCK_HELD: Cell<bool> = Cell::new(false));

fn main() {}

If that still shows the error, what does rustc filename.rs --pretty=expanded on that file show?

[SumiGovindaraju]

This still throws the same error:
cargo build:

   Compiling hello_world v0.1.0 (/Users/sumukhgovindaraju/github.com/Penn-Electric-Racing/hello_world)
error[E0433]: failed to resolve: could not find `__OsLocalKeyInner` in `thread`
 --> src/lib.rs:3:1
  |
3 | thread_local!(static LOCK_HELD: Cell<bool> = Cell::new(false));
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `__OsLocalKeyInner` in `thread`
  |
  = note: this error originates in the macro `$crate::__thread_local_inner` which comes from the expansion of the macro `thread_local` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0412]: cannot find type `__OsLocalKeyInner` in module `$crate::thread`
   --> src/lib.rs:3:1
    |
3   | thread_local!(static LOCK_HELD: Cell<bool> = Cell::new(false));
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a struct with a similar name exists: `__FastLocalKeyInner`
    |
   ::: /Users/sumukhgovindaraju/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:924:5
    |
924 |     pub struct Key<T> {
    |     ----------------- similarly named struct `__FastLocalKeyInner` defined here
    |
    = note: this error originates in the macro `$crate::__thread_local_inner` which comes from the expansion of the macro `thread_local` (in Nightly builds, run with -Z macro-backtrace for more info)

Some errors have detailed explanations: E0412, E0433.
For more information about an error, try `rustc --explain E0412`.
error: could not compile `hello_world` due to 2 previous errors

I tried running rustc src/lib.rs --pretty=expanded and rustc -Z unstable-options --pretty=expanded and both of them give the following error: error: Unrecognized option: 'pretty'. Is there an alternate command I can use?

[RalfJung]

@thomcc you're on macOS right? Any chance it's a aarch64-apple-darwin? AFAIK our CI builders are x86 machines, so maybe this has to do with the aarch64 target -- but I am sure we would have heard sooner if thread_local was entirely broken on aarch64-apple-darwin...

I tried running rustc src/lib.rs --pretty=expanded and rustc -Z unstable-options --pretty=expanded and both of them give the following error: error: Unrecognized option: 'pretty'. Is there an alternate command I can use?

Hm, that's what I get for copy-pasting commands from the web... I am looking for whatever the playground does when you ask it to 'expand macros'.

[RalfJung]

@SumiGovindaraju ah here we go: rustc -Zunpretty=expanded filename.rs. What does that print?

[SumiGovindaraju]

Any chance it's a aarch64-apple-darwin?

Yes, it is.

Output of rustc -Zunpretty=expanded src/lib.rs:

error[E0433]: failed to resolve: could not find `__OsLocalKeyInner` in `thread`
 --> src/lib.rs:3:1
  |
3 | thread_local!(static LOCK_HELD: Cell<bool> = Cell::new(false));
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `__OsLocalKeyInner` in `thread`
  |
  = note: this error originates in the macro `$crate::__thread_local_inner` which comes from the expansion of the macro `thread_local` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0412]: cannot find type `__OsLocalKeyInner` in module `$crate::thread`
   --> src/lib.rs:3:1
    |
3   | thread_local!(static LOCK_HELD: Cell<bool> = Cell::new(false));
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a struct with a similar name exists: `__FastLocalKeyInner`
    |
   ::: /Users/sumukhgovindaraju/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/std/src/thread/local.rs:924:5
    |
924 |     pub struct Key<T> {
    |     ----------------- similarly named struct `__FastLocalKeyInner` defined here
    |
    = note: this error originates in the macro `$crate::__thread_local_inner` which comes from the expansion of the macro `thread_local` (in Nightly builds, run with -Z macro-backtrace for more info)

#![feature(prelude_import)]
#![no_std]
#[prelude_import]
use ::std::prelude::rust_2015::*;
#[macro_use]
extern crate std;
use std::cell::Cell;


const LOCK_HELD: ::std::thread::LocalKey<Cell<bool>> =
    {
        #[inline]
        fn __init() -> Cell<bool> { Cell::new(false) }
        #[inline]
        unsafe fn __getit(init:
                ::std::option::Option<&mut ::std::option::Option<Cell<bool>>>)
            -> ::std::option::Option<&'static Cell<bool>> {
            #[cfg(all(not(target_thread_local),
            not(all(target_family = "wasm",
            not(target_feature = "atomics"))),))]
            static __KEY: ::std::thread::__OsLocalKeyInner<Cell<bool>> =
                ::std::thread::__OsLocalKeyInner::new();

            #[allow(unused_unsafe)]
            unsafe {
                __KEY.get(move ||
                        {
                            if let ::std::option::Option::Some(init) = init {
                                    if let ::std::option::Option::Some(value) = init.take() {
                                            return value;
                                        } else if true {
                                           ::core::panicking::panic_fmt(::core::fmt::Arguments::new_v1(&["internal error: entered unreachable code: "],
                                                   &[::core::fmt::ArgumentV1::new_display(&::core::fmt::Arguments::new_v1(&["missing default value"],
                                                                           &[]))]));
                                       }
                                }
                            __init()
                        })
            }
        }
        unsafe { ::std::thread::LocalKey::new(__getit) }
    };
fn main() {}
error: aborting due to 2 previous errors

Some errors have detailed explanations: E0412, E0433.
For more information about an error, try `rustc --explain E0412`.

[RalfJung]

(I was asking whether @thomcc also has an aarch64 macOS so we can compare.)

Okay so it somehow picks the (inefficient) OsLocalKeyInner, but only in one of two places. Argh that code is so messy. But I can't see how this could ever happen...

@thomcc is it expected that an aarch64 apple target would use OsLocalKeyInner rather than FastLocalKeyInner?

[RalfJung]

@SumiGovindaraju could I also ask you for the output of running this program, compiled with the same toolchain?

#![feature(cfg_target_thread_local)]
fn main() {
    dbg!(cfg!(target_thread_local));
    dbg!(cfg!(not(all(target_family = "wasm", not(target_feature = "atomics")))));
}

[SumiGovindaraju]

Output:

   Compiling test_crate v0.1.0 (/Users/sumukhgovindaraju/github.com/Penn-Electric-Racing/test_crate)
    Finished dev [unoptimized + debuginfo] target(s) in 0.35s
     Running `target/debug/test_crate`
[src/main.rs:3] cfg!(target_thread_local) = false
[src/main.rs:4] cfg!(not(all(target_family = "wasm", not(target_feature = "atomics")))) = true

[RalfJung]

So we really have cfg!(target_thread_local) = false. No idea if that is expected. And inexplicably, this does not get imported.

I am entirely unfamiliar with macOS details so I hope someone more familiar will pick this up here.

[SumiGovindaraju]

Hey, just was wondering if there was an update on this.