Skip to content

Delete the stage1 and stage0-sysroot directories when using download-rustc #102002

Closed
@jyn514

Description

@jyn514

@camelid: I just ran into something confusing with download-rustc: normal x.py build will build rustdoc and put it in stage1. However, x.py build with download-rustc enabled will put it in stage2. This means that rustdoc +stage1 ... won't run my local, modified version of rustdoc if download-rustc is set. Specifically, rustdoc +stage1 ... seems to run nightly rustdoc (or something static).

@bjorn3 suggests deleting the stage1 and stage0-sysroot directories when using download-rustc, to avoid caching issues like this. rustdoc +stage1 still won't do the right thing, but it will at least give a hard error instead of silently using the wrong version.

Originally posted by @jyn514 in #81930 (comment)

Metadata

Metadata

Assignees

Labels

A-download-rustcArea: The `rust.download-rustc` build option.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions