Skip to content

The number of arguments on Builder::bind_pattern are getting out of hand #101896

Closed
@oli-obk

Description

@oli-obk

We should clean up bind_pattern and other methods on the same type. I don't know yet how, we should first investigate the call sites and see if there are common patterns that can be merged:

  • two option args that are always both Some or both None
  • Maybe add an argument struct that defaults most fields
  • consider splitting it into multiple methods and then building named methods with fewer args around those split methods

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions