allow #[target_feature] on #[naked] functions

rust-lang · Jul 23, 2024 · 6f2318c · 6f2318c
1 parent 0ed639f
commit 6f2318c
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 27 deletions.
diff --git a/compiler/rustc_error_codes/src/error_codes/E0736.md b/compiler/rustc_error_codes/src/error_codes/E0736.md
@@ -5,7 +5,6 @@ Notable attributes that are incompatible with `#[naked]` are:
 
 * `#[inline]`
 * `#[track_caller]`
-* `#[target_feature]`
 * `#[test]`, `#[ignore]`, `#[should_panic]`
 
 Erroneous code example:

diff --git a/compiler/rustc_passes/src/check_attr.rs b/compiler/rustc_passes/src/check_attr.rs
@@ -423,7 +423,6 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
         //
         // * `#[inline]`
         // * `#[track_caller]`
-        // * `#[target_feature]`
         // * `#[test]`, `#[ignore]`, `#[should_panic]`
         //
         // NOTE: when making changes to this list, check that `error_codes/E0736.md` remains accurate
@@ -449,6 +448,7 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
             sym::naked,
             // code generation
             sym::cold,
+            sym::target_feature,
             // documentation
             sym::doc,
         ];

diff --git a/tests/ui/asm/naked-functions-target-feature.rs b/tests/ui/asm/naked-functions-target-feature.rs
diff --git a/tests/ui/asm/naked-functions-target-feature.stderr b/tests/ui/asm/naked-functions-target-feature.stderr
diff --git a/tests/ui/asm/naked-functions.rs b/tests/ui/asm/naked-functions.rs
@@ -231,6 +231,12 @@ pub unsafe extern "C" fn compatible_codegen_attributes() {
     asm!("", options(noreturn, att_syntax));
 }
 
+#[target_feature(enable = "sse2")]
+#[naked]
+pub unsafe extern "C" fn compatible_target_feature() {
+    asm!("", options(noreturn));
+}
+
 #[doc = "foo bar baz"]
 #[naked]
 pub unsafe extern "C" fn compatible_doc_attributes() {