Make --pids-limit a default feature
#49
Conversation
| .arg("--volume") | ||
| .arg(&mount_input_file) | ||
| .arg("--volume") | ||
| .arg(&mount_output_dir) |
There was a problem hiding this comment.
Could you undo these changes? I'm attempting to keep it as name, value to more easily match up what it does.
There was a problem hiding this comment.
Will do ! Sorry for that, it was a rustfmt slip-up. Had it enabled on file-save, which mangled the entire file. When I noticed that, I copied the entire function to keep my changes after checking the file back out. Lesson learned: Watch these diffs :) !
|
Alright, thanks for the feedback ! Please have a look to see whether the comments of been addressed. |
|
Great! I appreciate that you renamed the feature instead of just adding a comment. Would you mind squashing the 3 commits into one? If you'd rather, I can do it on my side. |
That way it is possible to not use the associateed `--pids-limit` flag by building like so: `cargo build --no-default-features` This is useful for local sandbox installations running on a different OS which doesn't directly support limiting PIDs, or which works differently in that regards. I am using coreOS for example, but admittedly also didn't try to find a way to make it work.
|
Squash successful ! Thanks for merging. |
|
For your own sanity, you may want to figure out how to enable PID limiting anyway. On Alpine Linux (for EC2), I had to do something like: To mount the appropriate cgroup. Having an up-to-date kernel and Docker was also useful. I'd be surprised if CoreOS doesn't support this in some manner. |
|
Indeed, for a production system I wouldn't want to have it any other way either. By the way, for inspiration I recommend having a look at the Crystal Playground implementation. You can run it simply using
|
That way it is possible to not use this flag by building like so:
cargo build --no-default-featuresThis is useful for local sandbox installations running on a different
OS which doesn't directly support limiting PIDs, or which works
differently in that regards.
I am using coreOS for example, but admittedly also didn't try
to find a way to make it work.