-
Notifications
You must be signed in to change notification settings - Fork 222
Better define the scope of rustdoc members roles #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
rustbot has assigned @aDotInTheVoid. Use |
src/rustdoc/membership.md
Outdated
|
|
||
| - Front-end: Everything related to HTML/CSS/JS | ||
| - JSON backend: Work on the `--output-format=json` backend. | ||
| - Front-end: Everything related to HTML/CSS/JS and (HTML) UI/UX changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see anything that needs clarification?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obvious question is that you haven't mentioned search in any of these. I think it's considered front-end, since it's HTML-specific, but we should probably say so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifying the scope of each team a bit more precisely then.
|
I mean, looks sensible, but I'm not sure how is it related to t-infra? 😅 |
|
For the add of new roles/tags. Also I'm not sure if it works for RFCs yet. |
| [team repository](https://github.com/rust-lang/team) and is called `rustdoc-frontend`. If a rustdoc | ||
| team member is interested to be part of this group, they can ask to be added into it. | ||
|
|
||
| Rustdoc roles handle their own FCPs and RFCs if it only impacts their own area, otherwise other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this require making a rustdoc-json-backend team (which is probably worthwhile doing anyway)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, hence why I pinged the infra team. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Just send a PR to team and that should be it :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dully noted. ;)
Since the experiment with the @rust-lang/rustdoc-frontend was a success, I think we can now add the two other roles:
rustdoc-json-backendandrustdoc-internals. That will require for the infra team to also give their opinion here (cc @Kobzol).cc @rust-lang/rustdoc
Rendered