-
Notifications
You must be signed in to change notification settings - Fork 195
Make blacksmith optional #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I also find it strange that to build this documentation website I need to download about 60mb to build a cache file. The cache seems to have the complete matrix of rustc builds for all versions ever (was implemented in #249). I struggle to understand what is this file used for. Any help? |
It's essentially used for automating the generation of this page and a few other pieces of information. It's mostly only useful for CI, so we could also just make it optional, e.g. based on |
ah ok understood. Another option (but I don't know how much work would it be), that file could be generated and stored server-side. blacksmith could just download it (with gzip compression is just 1,3KiB) |
Well, it also contains the nightly and beta releases, so it changes at least ~once per day, so we would have to run some cron job on the repo or something to keep it up-to-date 😆 I would just do the simpler thing and increase TTL, or make it be optional. |
In any case, what blacksmith is, does and why would probably be a good thing to mention briefly in the README |
I vote for this |
I think I would also vote for this. I find it pretty annoying, and the number of people who need to work on the rendering of that releases page is much smaller than the number of people who work on the forge in general. |
Ok, made blacksmith CI only and documented it a bit. |
Ok, should be ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now builds in 1s (lol)
Pretty much everytime I build/serve the Forge when I want to change something, I have to wait for blacksmith to download Rust releases. It's so annoying that I actually see this as a contribution roadblock to the Forge :) New stable releases are released every six weeks, and for local development you don't care about having the releases downloaded 99.99% of the time, so I really don't think we need to update the cache every hour. You can always just flush the cache by removing the JSON file.