Stabilizing const functions #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
reviewed
Feb 26, 2020
Centril
reviewed
Feb 26, 2020
|
@KodrAus 👋 :) |
|
Oh no, I added a note about this in this PR. Sorry for not checking for an existing PR :< |
|
Sorry @Centril! 🙇 I fell off the radar for a while 🙂 @LukasKalbertodt don't even worry about it! ❤️ I think we should all feel free to drop bits and pieces in here without too much concern for things being repeated or not fully organized yet. |
KodrAus
force-pushed
the
KodrAus/std-docs-updates
branch
from
3e2a3d4 to
43210f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @rust-lang/libs @rust-lang/wg-const-eval
In rust-lang/rust#69373 (comment) it was noted that stabilizing the
const-ness of functions should include the WG. Should this only really be necessary when there are internal unstable const features used in those stabilizing functions?@ecstatic-morse offered some guidelines on things to keep in mind when stabilizing
constfunctions with internally unstable features. Would you like that to be included here?