Add Rollup Procedure #268
Merged
Add Rollup Procedure #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
reviewed
Oct 20, 2019
Centril
reviewed
Oct 20, 2019
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Centril
reviewed
Oct 21, 2019
JohnTitor
reviewed
Oct 21, 2019
Co-Authored-By: Yuki Okushi <huyuumi.dev@gmail.com>
JohnTitor
reviewed
Oct 23, 2019
Co-Authored-By: Yuki Okushi <huyuumi.dev@gmail.com>
|
@Centril Updated, could you re-review it? |
Centril
reviewed
Oct 23, 2019
src/release/rollups.md
Outdated
| PR, `@bors rollup-` to un-mark as a rollup). 'Performing a Rollup' then means | ||
| collecting these changes into one PR and merging them all at once. The rollup | ||
| command accepts three values `always`, `maybe`, and `never`. `@bors rollup` is | ||
| equivalent to `rollup=always` (which will always put a PR in a rollup), and |
There was a problem hiding this comment.
Note: these commands, aside from rollup (which will make the priority effectively negative) don't actually have any automatic effect like that; it is a suggestion to the person making a rollup.
There was a problem hiding this comment.
Reworded to make that distinction more clear.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #87 with what @Centril has written about the current rollup procedure.
r? @Centril