Skip to content

Cleanup rustc_tool_util and add a convenient macro for build.rs #9927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2022
Merged

Cleanup rustc_tool_util and add a convenient macro for build.rs #9927

merged 2 commits into from
Dec 15, 2022

Conversation

xFrednet
Copy link
Member

@xFrednet xFrednet commented Nov 21, 2022 •
edited
Loading

changelog: none

If possible, I'd like to have a new release for this, maybe v0.3.0 to use the changes in another project. Then we can also remove the path = "./rustc_tools_util" from Cargo.toml. I'd be happy to help with the release on crates.io if you'd like the help :)

r? @matthiaskrgr

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 21, 2022
@xFrednet xFrednet force-pushed the 0000-rustc-tool-macro-update branch 2 times, most recently from 6f630a4 to f711fcb Compare November 21, 2022 22:26
@xFrednet xFrednet force-pushed the 0000-rustc-tool-macro-update branch from f711fcb to aa66212 Compare November 21, 2022 22:28
matthiaskrgr
matthiaskrgr reviewed Nov 24, 2022
View reviewed changes
@xFrednet
Copy link
Member Author

xFrednet commented Dec 1, 2022

Hey @matthiaskrgr, have you seen my answers on the PR :)

@matthiaskrgr
Copy link
Member

I tried to add @xFrednet and @flip1995 to the list of crate owners on crates.io, you should have gotten invites or something.

I also looked if I can add the rust-lang/clippy team as a crate owner (I saw some other crates do this) but I'm not sure what "user id" notation I need to use.

matthiaskrgr
matthiaskrgr approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@matthiaskrgr matthiaskrgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all LGTM! 🎉

Feel to publish a new version and r=me @xFrednet

@xFrednet
Copy link
Member Author

Awesome, thank you very much! I'm busy in the next few days but will get to it during the week :)

I remember crates.io being a bit weird with groups. It requires a name like github:rust-lang:clippy, I'll try looking that up and adding the team, if that's fine with you?🙃

@xFrednet xFrednet force-pushed the 0000-rustc-tool-macro-update branch from 7d848bc to 9691161 Compare December 15, 2022 11:43
@xFrednet
Copy link
Member Author

Sir bors, would you be so kind and merge this magnificent code into master?

@bors
Copy link
Contributor

bors commented Dec 15, 2022

📌 Commit 9691161 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 15, 2022

⌛ Testing commit 9691161 with merge 0fe8e9f...

bors added a commit that referenced this pull request Dec 15, 2022
@bors
Auto merge of #9927 - xFrednet:0000-rustc-tool-macro-update, r=matthi…
0fe8e9f 
…askrgr

Cleanup `rustc_tool_util` and add a convenient macro for `build.rs`

changelog: none
<!-- changelog_checked -->

If possible, I'd like to have a new release for this, maybe `v0.3.0` to use the changes in another project. Then we can also remove the `path = "./rustc_tools_util"` from `Cargo.toml`. I'd be happy to help with the release on crates.io if you'd like the help :)

r? `@matthiaskrgr`
@bors
Copy link
Contributor

bors commented Dec 15, 2022

💔 Test failed - checks-action_test

@xFrednet xFrednet force-pushed the 0000-rustc-tool-macro-update branch from 9691161 to 004b885 Compare December 15, 2022 12:01
@xFrednet
Copy link
Member Author

Lord bors, I once again ask for your support. Please give me a merge commit!

@xFrednet
Copy link
Member Author

@bors r=matthiaskrgr

@bors
Copy link
Contributor

bors commented Dec 15, 2022

📌 Commit 004b885 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 15, 2022

⌛ Testing commit 004b885 with merge f43e4f3...

@bors
Copy link
Contributor

bors commented Dec 15, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing f43e4f3 to master...

@bors bors merged commit f43e4f3 into rust-lang:master Dec 15, 2022
@xFrednet xFrednet deleted the 0000-rustc-tool-macro-update branch December 15, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiaskrgr matthiaskrgr matthiaskrgr approved these changes

Assignees

@matthiaskrgr matthiaskrgr

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xFrednet @matthiaskrgr @bors @rust-highfive