Skip to content

Use LazyLock for lint_message_convention regexes #9169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

Alexendoo
Copy link
Member

They were being recompiled for Message::new call, for me this shaves 7s off the time it takes to run the test. Also removes a redundant exception from the list and joins the various message... exceptions into one

changelog: none

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 13, 2022
@flip1995
Copy link
Member

Nice!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 13, 2022

📌 Commit 018684d has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 13, 2022

⌛ Testing commit 018684d with merge 44be2d4...

@bors
Copy link
Contributor

bors commented Jul 13, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 44be2d4 to master...

@bors bors merged commit 44be2d4 into rust-lang:master Jul 13, 2022
@Alexendoo Alexendoo deleted the message-convention-regex branch July 13, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants