-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add std_instead_of_core, std_instead_of_alloc, alloc_instead_of_core
#9103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. Please see the contribution instructions for more information. |
cbbf4bb to
7070ed9
Compare
std_instead_of_core, std_instead_of_alloc, alloc_instead_of_core
|
☔ The latest upstream changes (presumably #9105) made this pull request unmergeable. Please resolve the merge conflicts. |
Manishearth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just needs a rebase!
7070ed9 to
dedf8b8
Compare
|
Fixed the merge conflicts |
dedf8b8 to
435f115
Compare
|
Fixed, good thing |
435f115 to
2f825db
Compare
|
@bors r+ thanks! |
|
Looks like bors was sleeping. I've added a changelog entry for the new lints @bors r=Manishearth |
|
@bors ping |
|
😪 I'm awake I'm awake |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Closes #7724
Introduces 3 new lints:
std_instead_of_core- lints items resolved throughstdwhich are available incorestd_instead_of_alloc- lints items resolved throughstdwhich are available inallocalloc_instead_of_core- lints items resolved throughallocwhich are available incoreThough the original issue only mentions
std_instead_of_alloc, the other two lints could be useful as well.questions:
std_reexports?changelog: new lint's: [
std_instead_of_core], [std_instead_of_alloc], [alloc_instead_of_core]