Lint simple expressions in manual_filter_map, manual_find_map
#8958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
giraffate
reviewed
Jul 7, 2022
Contributor
giraffate
left a comment
giraffate
left a comment
There was a problem hiding this comment.
Sorry for the late reviewing.
Overall looks good, thanks! I made one comment.
| target_span: Span, | ||
| methods_span: Span, | ||
| ) { | ||
| ) -> bool { |
Contributor
There was a problem hiding this comment.
IMO it would be better to separate function into one that check and return bool and one that just emit the lint. I was confused that the function name lint_filter_some_map_unwrap return bool.
Member
Author
There was a problem hiding this comment.
Thanks, changed it to be an is_ function
Alexendoo
force-pushed
the
simple_filter_map
branch
from
9e362ba to
307b8cd
Compare
Contributor
|
@bors r+ Thanks! |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Lint simple expressions in [
manual_filter_map], [manual_find_map]The current comparison rules out
.find(|a| a.is_some()).map(|b| b.unwrap())becauseabeing a reference can effect more complicated expressions, this adds a simple check for that case and adds the necessary derefsThere's some overlap with
option_filter_mapsolint_filter_some_map_unwrapnow returns aboolto indicate it linted