get_last_with_len: lint VecDeque and any deref to slice
#8862
Conversation
|
r? @xFrednet (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @Jarcho 🙃 |
| // check that recv == lhs_recv `recv.get(lhs_recv.len() - 1)` | ||
| && path_to_local(lhs_recv) == Some(recv_local) | ||
| { | ||
| let method = match cx.typeck_results().expr_ty_adjusted(recv).peel_refs().kind() { |
There was a problem hiding this comment.
Quick question here. This allows any type which derefs to a VecDeque or a slice. Is that intentional?
There was a problem hiding this comment.
I don't know if you want to handle this horrible case or not:
struct Foo(Vec<u32>);
impl Deref for Foo { type Target = Vec<u32>; ... }
impl Foo {
// Only replace `last`, but not `get`
fn last(&self) -> SomeType { ... }
}I don't think it's necessary to do so. It's kind of a pathological case.
There was a problem hiding this comment.
I'm happy to leave that one out, can't imagine it coming up
Alexendoo
force-pushed
the
get-last-with-len
branch
from
f2964f2 to
6379276
Compare
|
Can you add a test for a field access as well just to make sure it doesn't break in the future. Otherwise looks good. @xFrednet I don't know if you want to add anything before merging. |
previously only vecs were supported
Alexendoo
force-pushed
the
get-last-with-len
branch
from
6379276 to
8558490
Compare
|
👍 added |
|
📌 Commit 8558490 has been approved by |
`get_last_with_len`: lint `VecDeque` and any deref to slice changelog: [`get_last_with_len`]: lint `VecDeque` and any deref to slice Previously only `Vec`s were linted, this will now catch any usages on slices, arrays, etc. It also suggests `.back()` for `VecDeque`s Also moves the lint into `methods/`
|
💔 Test failed - checks-action_test |
|
Seems like some CI weirdness. Maybe bors wanted a break ^^ @bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: [
get_last_with_len]: lintVecDequeand any deref to slicePreviously only
Vecs were linted, this will now catch any usages on slices, arrays, etc. It also suggests.back()forVecDequesAlso moves the lint into
methods/