Skip to content

Retry on some download errors in lintcheck #7694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Sep 20, 2021

I'm currently on spotty wifi right now. It is shocking the number of things that break when you lose connection for a few seconds. Some 500 errors should probably also be retried, but this fixes my issue.

changelog: None

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 20, 2021
@flip1995
Copy link
Member

r? @matthiaskrgr (If you don't have time to review this, just throw it back to me)

@rust-highfive rust-highfive assigned matthiaskrgr and unassigned llogiq Sep 21, 2021
Copy link
Member

@matthiaskrgr matthiaskrgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

@matthiaskrgr
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 21, 2021

📌 Commit 41fe546 has been approved by matthiaskrgr

@bors
Copy link
Contributor

bors commented Sep 21, 2021

⌛ Testing commit 41fe546 with merge 848e551...

@bors
Copy link
Contributor

bors commented Sep 21, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing 848e551 to master...

@bors bors merged commit 848e551 into rust-lang:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants