Skip to content

Set applicability of needless_collect to MaybeIncorrect #7602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

flip1995
Copy link
Member

Fixes rust-lang/rust#88333

changelog: Set applicability of [needless_collect] to MaybeIncorrect

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 26, 2021
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix 🙃

Before merging, I have a question about the changelog entry: Do we want to start tracking applicability changes in our changelog as well?

@flip1995
Copy link
Member Author

Do we want to start tracking applicability changes in our changelog as well?

Not sure. I planned to let the person writing the changelog to make this decision. 😄

@xFrednet
Copy link
Member

xFrednet commented Aug 26, 2021

Sounds good to me xD

@bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2021

📌 Commit c6e4202 has been approved by xFrednet

@bors
Copy link
Contributor

bors commented Aug 26, 2021

⌛ Testing commit c6e4202 with merge a4a3f61...

@bors
Copy link
Contributor

bors commented Aug 26, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing a4a3f61 to master...

@bors bors merged commit a4a3f61 into rust-lang:master Aug 26, 2021
@flip1995 flip1995 deleted the needless_collect_appl branch August 26, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errors after cargo clippy --fix
5 participants