Fix new_ret_no_self false positive
#6952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Jarcho
force-pushed
the
new_ret_no_self_fp
branch
from
1321da5 to
6181a4b
Compare
Manishearth
reviewed
Mar 23, 2021
|
☔ The latest upstream changes (presumably #6957) made this pull request unmergeable. Please resolve the merge conflicts. |
…different generic arguments
Jarcho
force-pushed
the
new_ret_no_self_fp
branch
from
4caa00d to
6e88900
Compare
Manishearth
approved these changes
Mar 24, 2021
|
@bors r+ thanks! |
|
📌 Commit 6e88900 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1724
changelog: Fix false positive with
new_ret_no_selfwhen returningSelfwith different generic arguments